Ensure the request init hook is bound by the open_basedir INI directive #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
force-pushed
the
sammyk/sandbox-request-init-hook
branch
from
e19c081
to
035cf08
Compare
morrisonlevi
approved these changes
Sep 18, 2019
SammyK
force-pushed
the
sammyk/sandbox-request-init-hook
branch
from
035cf08
to
20478c8
Compare
SammyK
added
c-extension
SammyK
force-pushed
the
sammyk/sandbox-request-init-hook
branch
2 times, most recently
from
4f4f503
to
58e8e98
Compare
Also sandbox the request init hook so that errors and exceptions are ignored
SammyK
force-pushed
the
sammyk/sandbox-request-init-hook
branch
from
58e8e98
to
d648734
Compare
SammyK
added a commit
that referenced
this pull request
Sep 18, 2019
Ensure the request init hook is bound by the open_basedir INI directive
SammyK
added a commit
that referenced
this pull request
Sep 19, 2019
Ensure the request init hook is bound by the open_basedir INI directive
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the
ddtrace.request_init_hookis still bound by theopen_basedirINI directive. It also sandboxes the request init hook so that errors or exceptions within the request init hook do not affect the main script execution.Readiness checklist
[ ] Tests added for this feature/bug.The master build tests are expected to fail for this PR; this will be addressed ASAPReviewer checklist