Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PHP API check more specific #590

Merged
merged 1 commit into from Sep 30, 2019
Merged

Make PHP API check more specific #590

merged 1 commit into from Sep 30, 2019

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Sep 26, 2019 •
edited

Description

This fixes a post-install issue with determining the PHP version. Supersedes #587 and fixes #586. Thanks Dan Sapala!

Readiness checklist

  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the appropriate release draft. For community contributors the reviewer is in charge of this task.

@morrisonlevi morrisonlevi added 🐛 bug Something isn't working packaging labels Sep 26, 2019
@morrisonlevi morrisonlevi added this to the 0.31.0 milestone Sep 26, 2019
@morrisonlevi morrisonlevi mentioned this pull request Sep 26, 2019
Closed
5 tasks
@morrisonlevi morrisonlevi force-pushed the levi/issue-586 branch 2 times, most recently from 337047a to 4c13825 Compare September 26, 2019 23:20
@morrisonlevi
Copy link
Collaborator Author

Note that on some platforms [[:space:]] wasn't supported, so this changed to [ \t].

SammyK
SammyK approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @iedsapala! :)

@morrisonlevi morrisonlevi merged commit c004025 into master Sep 30, 2019
@labbati labbati deleted the levi/issue-586 branch October 11, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

dd-trace-php post-install.sh file regex isn't specific enough
3 participants
@morrisonlevi @SammyK @iedsapala