Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execinfo on builds from source in Alpine containers #752

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix execinfo on builds from source in Alpine containers #752

merged 2 commits into from
Feb 20, 2020

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Feb 12, 2020 •
edited

Description

This -lexecinfo check is needed for Alpine containers where execinfo is a separate library from the libc. Relates to #381.

Also fixes some mixed tabs and spaces.

Readiness checklist

  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the appropriate release draft.

@morrisonlevi
Check for -lexecinfo if execinfo.h is found
7f49976 
This is needed for Alpine containers where execinfo is a separate
library from the libc.
@morrisonlevi morrisonlevi added 🐛 bug Something isn't working c-extension Apply this label to issues and prs related to the C-extension labels Feb 12, 2020
@morrisonlevi morrisonlevi changed the title Check for -lexecinfo if execinfo.h is found Fix execinfo on Alpine containers Feb 12, 2020
@morrisonlevi morrisonlevi changed the title Fix execinfo on Alpine containers Fix execinfo on builds from source in Alpine containers Feb 20, 2020
labbati
labbati approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@morrisonlevi morrisonlevi merged commit d4fbc44 into master Feb 20, 2020
@morrisonlevi morrisonlevi deleted the levi/build-execinfo branch February 20, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labbati labbati labbati approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working c-extension Apply this label to issues and prs related to the C-extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morrisonlevi @labbati