Put compile_file hook behind a feature flag, default on #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
reviewed
Feb 18, 2020
This only tests the high-level part where the metric is set on the span; it doesn't test the gathering, which is actually what should be tested.
morrisonlevi
force-pushed
the
levi/build-compile-file
branch
from
7f3d31c
to
6fe1b87
Compare
SammyK
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
compile_filehook will delay compiling files a little bit by measuring how long it takes. If those files are prone to SIGBUS then this hook will exacerbate those issues by keeping them open slightly longer.This flag defaults to on as most customers do not have this issue, but those who do have it can turn it off by setting
DD_TRACE_MEASURE_COMPILE_TIME=falsein their environment.Readiness checklist
Reviewer checklist