Add support for DD_VERSION and DD_ENV variables #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettlangdon thanks for the work on this. I can download it tomorrow first thing in the morning and play with it to understand why it is not failing, as I am surprised as well |
|
well, by default it won't add actually modify anything, if no env variables are provided, then no changes to spans. |
…ngdon/dd.version.env
…nctions dual approach
labbati
reviewed
Jun 12, 2020
| $this->assertTrue(empty($traces[0][0]['meta']['env'])); | ||
| } | ||
|
|
||
| public function testDDEnvHasPrecendenceOverGlobalTags() |
labbati
reviewed
Jun 12, 2020
| $this->assertTrue(empty($traces[0][0]['meta']['version'])); | ||
| } | ||
|
|
||
| public function testDDVersionHasPrecendenceOverGlobalTags() |
SammyK
approved these changes
Jun 15, 2020
|
|
||
| // Application version | ||
| if (null !== $this->serviceVersion) { | ||
| $span->setTag(Tag::VERSION, $this->serviceVersion); |
There was a problem hiding this comment.
Just want to confirm that it was intentional to not use Tag::SERVICE_VERSION here, correct?
There was a problem hiding this comment.
That's correct. Tag::SERVICE_VERSION =service.version is only there for compatibility for OpenTelemetry. What we want to set is version.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for
DD_VERSIONandDD_ENVenvironment variables.These variables should set default global tags of
versionandenvon every span generated.Readiness checklist
Reviewer checklist