Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return that the sandboxed Guzzle integration loaded #816

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Return that the sandboxed Guzzle integration loaded #816

merged 1 commit into from
Apr 13, 2020

Conversation

morrisonlevi
Copy link
Collaborator

Description

This is a tiny bugfix to #809; I forgot to return Integration::LOADED which causes entries like this to show up in the debug log:

[2020-04-10T20:29:07+00:00] [ddtrace] [error] - Invalid value returning by integration loader for guzzle:

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the appropriate release draft.

@morrisonlevi morrisonlevi added 🐛 bug Something isn't working 🎉 new-integration A new integration labels Apr 10, 2020
@morrisonlevi morrisonlevi added this to the 0.43.0 milestone Apr 10, 2020
@morrisonlevi morrisonlevi merged commit 9acd64b into master Apr 13, 2020
@morrisonlevi morrisonlevi deleted the levi/guzzle branch April 13, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working 🎉 new-integration A new integration
Projects
None yet
Milestone
0.43.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morrisonlevi @SammyK