Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto flush with userland root span #826

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Auto flush with userland root span #826

merged 2 commits into from
Apr 16, 2020

Conversation

SammyK
Copy link
Contributor

@SammyK SammyK commented Apr 15, 2020 •
edited

Description

This followup PR to #819 enables auto flushing when the root span is created in userland. Before this, only internal root spans would trigger auto flushing.

This also includes a fix to disable instrumentation during auto flushing to prevent infinite recursion.

Readiness checklist

  • (only for Members) Changelog has been added to the appropriate release draft. Create one if necessary.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the appropriate release draft. For community contributors the reviewer is in charge of this task.

@SammyK SammyK added 🍏 core Changes to the core tracing functionality c-extension Apply this label to issues and prs related to the C-extension 📦 Sandbox API labels Apr 15, 2020
@SammyK SammyK added this to the 0.44.0 milestone Apr 15, 2020
morrisonlevi
morrisonlevi approved these changes Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and the workflow I used to find this bug doesn't have this issue anymore 👍

@SammyK SammyK merged commit 5a70d15 into master Apr 16, 2020
@SammyK SammyK deleted the sammyk/fix-auto-flush branch April 16, 2020 14:39
@SammyK SammyK modified the milestones: 0.44.0, 0.43.0 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

Assignees
No one assigned
Labels
c-extension Apply this label to issues and prs related to the C-extension 🍏 core Changes to the core tracing functionality 📦 Sandbox API
Projects
None yet
Milestone
0.43.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SammyK @morrisonlevi