Add Memcached integration tests #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
force-pushed
the
test/memcached
branch
2 times, most recently
from
7844191
to
925ff0e
Compare
labbati
force-pushed
the
test/memcached
branch
from
925ff0e
to
d3327a8
Compare
pawelchcki
requested changes
Nov 5, 2018
| }); | ||
| // A note about xxxMulti from Memcached integration docblock: | ||
| // | ||
| // setMulti and deleteMulti don't generate out.host and out.port because it |
There was a problem hiding this comment.
Unrelated PR - but maybe it would worthwhile (if possible) to tag such operation with 'every' used Memcache out.host, out.port pair?
There was a problem hiding this comment.
Added a reminder to investigate this possibility, as it would be an interesting info to add. Thanks for noticing
|
Looking at the tests now looks like PHP 5.6 is failing. I wonder if it would be possible to temporarily skip this testsuite only on PHP 5.6 so that its not obscuring other failures. |
|
Back to @pawelchcki for final review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.