Add Laravel 5.7 and 4.2 sample apps #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
force-pushed
the
test/laravel-test-app
branch
from
0f1d366
to
2bb93cf
Compare
pawelchcki
requested changes
Nov 5, 2018
There was a problem hiding this comment.
Looks Good! But...
Would be great to document inside one of repository docs, how these projects were generated, so that its easy to redo-it if need be. Even if its very simple and standard command. This way we'll know down the line that it was standard command.
"Some" tests are failing :)
labbati
force-pushed
the
test/laravel-test-app
branch
from
e9dd72f
to
b5a565a
Compare
labbati
force-pushed
the
test/laravel-test-app
branch
from
b5a565a
to
27a83d8
Compare
|
Assigning back to @pawelchcki for final round of CR. These are the code changes after your lastest CR: https://github.com/DataDog/dd-trace-php/compare/2bb93cfd028e80a4f388c07106b0288174cfba11...27a83d8?expand=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sample Laravel 4.2 and 5.7 apps to the repo to be used during tests. It has been created through
composer create-project laravel/laravel your-project-name x.x.*command and a few folders have been removed.In the future can be optimized, but for now we just push the entire default apps.
This PR just push the sample apps and not tests or shared code, so it can be easily merged. Work on tests will be done on a different branch.