New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox cURL (PHP 5) #911
Merged
Merged
Sandbox cURL (PHP 5) #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
added
c-extension
Apply this label to issues and prs related to the C-extension
📦 Sandbox API
labels
Jun 2, 2020
morrisonlevi
reviewed
Jun 4, 2020
SammyK
force-pushed
the
sammyk/build/sandbox-curl-php5
branch
from
June 4, 2020 23:01
70136da
to
6cb95c9
Compare
SammyK
force-pushed
the
sammyk/build/sandbox-curl-php5
branch
from
June 4, 2020 23:27
6cb95c9
to
1da2232
Compare
morrisonlevi
force-pushed
the
sammyk/build/sandbox-curl-php5
branch
from
June 5, 2020 16:51
6f38016
to
abc2853
Compare
morrisonlevi
force-pushed
the
sammyk/build/sandbox-curl-php5
branch
from
June 5, 2020 17:32
abc2853
to
0066135
Compare
This is needed in oder to support the configurable sampler which allows custom sampling priorities per service or span name.
SammyK
force-pushed
the
sammyk/build/sandbox-curl-php5
branch
from
June 9, 2020 17:34
c28be00
to
d2672f7
Compare
morrisonlevi
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing if static analysis is required for merge.
morrisonlevi
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Sammy. Thanks for wading through PHP 5!
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up PR to #814. This sandboxes the cURL integration on PHP 5.6 (PHP 5.4 is still limited to the legacy API so it does not apply.)
As in #814, this PR also provides custom internal function handlers for
curl_exec
,curl_copy_handle
,curl_close
,curl_setopt
, andcurl_setopt_array
in order to inject distributed tracing headers. This PR differs slightly from #814 by injecting the distributed tracing headers with a single userland call toDDTrace\Bridge\curl_inject_distributed_headers()
right before thecurl_exec()
call. This approach can be used for PHP 7 to reduce the dependency on the userland API.Readiness checklist
Reviewer checklist