Add nginx + php-fpm example app for docs #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
reviewed
Jul 1, 2020
examples/nginx-php-fpm/README.md
Outdated
|
|
||
| ## Nginx configuration | ||
|
|
||
| Nothing specific has to change here. [default.com](default.conf) file you see in this example has no changes required specific to the tracing library. |
examples/nginx-php-fpm/README.md
Outdated
|
|
||
| Nothing specific has to change here. [default.com](default.conf) file you see in this example has no changes required specific to the tracing library. | ||
|
|
||
| *Note*: if you come from a older version you might have used `fastcgi_param`s to configure the tracer. This approach is now deprecated in favor of `env` directive in the fpm pool configuration. See next section. |
There was a problem hiding this comment.
s/from a older/from an older/
Although, we could reword it a bit for specificity: "If you are upgrading from an older version of ddtrace..."
|
Thanks @SammyK, typos fixed |
SammyK
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
(only for Members) Changelog has been added to the appropriate release draft. Create one if necessary.Tests added for this feature/bug.Reviewer checklist