Enable sandboxed integration for Symfony on PHP 5 #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Sammy guesses that it's because we didn't support close-on-exit on PHP 5 at the time
This is correct. We have users using Symfony with exit() and we were not supporting exit on sandboxed for 5.6.
Looks good to me to be merged. Good catch @morrisonlevi!
This was referenced Jul 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This integration was already written; it just wasn't enabled. Sammy guesses that it's because we didn't support close-on-exit on PHP 5 at the time. We support it on PHP 5.6 now, so this should be good to go as long as the tests pass in CI.
Readiness checklist
Reviewer checklist