Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gdbinit files from released PHP versions #996

Merged
merged 4 commits into from Aug 26, 2020
Merged

Add .gdbinit files from released PHP versions #996

merged 4 commits into from Aug 26, 2020

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Aug 22, 2020 •
edited

Description

This adds .gdbinit files from each version of PHP. Critically, this adds the zbacktrace command which shows the backtrace of the PHP call stack, rather than the C backtrace you see with bt or backtrace.

Usage:

source .gdbinit-5.6
zbacktrace

Readiness checklist

  • Changelog has been added to the release document.
  • Tests added for this feature/bug. This is a tooling change only.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document.

@morrisonlevi
Add .gdbinit files from released PHP versions
5f67c9f 
Inside of gdb, you source a file eg

(gdb) source .gdbinit-5.6

And then the `zbacktrace` command is available:

(gdb) zbacktrace
@morrisonlevi
Ignore .gdbinit files for eclint
9986df8
@morrisonlevi morrisonlevi added c-extension Apply this label to issues and prs related to the C-extension cat:devtools labels Aug 22, 2020
@morrisonlevi morrisonlevi added this to the 0.49.0 milestone Aug 25, 2020
SammyK
SammyK reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we possibly move these into a folder? :)

@morrisonlevi
Copy link
Collaborator Author

Any suggestions? tooling/?

@SammyK
Copy link
Contributor

SammyK commented Aug 25, 2020

👍 for the existing tooling directory.

SammyK
SammyK approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@morrisonlevi morrisonlevi merged commit e1a34d4 into master Aug 26, 2020
@morrisonlevi morrisonlevi deleted the levi/gdbinit branch August 26, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
c-extension Apply this label to issues and prs related to the C-extension cat:devtools
Projects
None yet
Milestone
0.49.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morrisonlevi @SammyK