Skip to content

Commit

Permalink
Cap setuptools_scm <6.1 (#2816)
Browse files Browse the repository at this point in the history
* Cap setuptools_scm <6.1
setuptool_scm>=6.1 has had issues with external dependencies and changing extras
pypa/setuptools_scm#611
pypa/setuptools_scm#605

* Add release note

* also update pyproject.toml
  • Loading branch information
brettlangdon committed Aug 27, 2021
1 parent 2927a37 commit 5b8d345
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools >= 40.6.0", "setuptools_scm[toml] >= 4", "cython"]
requires = ["setuptools >= 40.6.0", "setuptools_scm[toml] >=4,<6.1", "cython"]
build-backend = "setuptools.build_meta"

[tool.setuptools_scm]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Pin ``setup_requires`` dependency ``setuptools_scm[toml]>=4,<6.1`` to avoid breaking changes.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def get_exts_for(name):
"Programming Language :: Python :: 3.9",
],
use_scm_version={"write_to": "ddtrace/_version.py"},
setup_requires=["setuptools_scm[toml]>=4", "cython"],
setup_requires=["setuptools_scm[toml]>=4,<6.1", "cython"],
ext_modules=ext_modules
+ cythonize(
[
Expand Down

0 comments on commit 5b8d345

Please sign in to comment.