Skip to content

Commit

Permalink
chore(ci): disable flaky benchmark test (#9223)
Browse files Browse the repository at this point in the history
This benchmark test returns timeout and it's blocking the CI


## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
avara1986 committed May 10, 2024
1 parent 5d96a5d commit 7f679b3
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .gitlab/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,11 @@ appsec-iast-propagation:
variables:
SCENARIO: "appsec_iast_propagation"

benchmark-encoder:
extends: .benchmarks
variables:
SCENARIO: "encoder"
# Flaky benchmark test. Timeout errors
#benchmark-encoder:
# extends: .benchmarks
# variables:
# SCENARIO: "encoder"

benchmark-http-propagation-extract:
extends: .benchmarks
Expand Down

0 comments on commit 7f679b3

Please sign in to comment.