Skip to content

Commit

Permalink
chore(framework test): unpin sqlalchemy for fastapi framework tests (#…
Browse files Browse the repository at this point in the history
…4963)

## Description
The fsatapi framework tests currently pin sqlalchemy to 1.4.41 due to an
upstream issue which has now closed:
encode/databases#512. It looks like we can
unpin this dependency.

Fixes #4800.

## Checklist
- [ ] Followed the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
when writing a release note.
- [ ] Add additional sections for `feat` and `fix` pull requests.
- [ ] [Library
documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs)
and/or [Datadog's documentation
site](https://github.com/DataDog/documentation/) is updated. Link to doc
PR in description.

<!-- Copy and paste the relevant snippet based on the type of pull
request -->

<!-- START feat -->

## Motivation
<!-- Expand on why the change is required, include relevant context for
reviewers -->

## Design 
<!-- Include benefits from the change as well as possible drawbacks and
trade-offs -->

## Testing strategy
<!-- Describe the automated tests and/or the steps for manual testing.

<!-- END feat -->

<!-- START fix -->

## Relevant issue(s)
<!-- Link the pull request to any issues related to the fix. Use
keywords for links to automate closing the issues once the pull request
is merged. -->

## Testing strategy
<!-- Describe any added regression tests and/or the manual testing
performed. -->

<!-- END fix -->

## Reviewer Checklist
- [x] Title is accurate.
- [x] Description motivates each change.
- [x] No unnecessary changes were introduced in this PR.
- [x] Avoid breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Tests provided or description of manual testing performed is
included in the code or PR.
- [x] Release note has been added and follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines),
or else `changelog/no-changelog` label added.
- [x] All relevant GitHub issues are correctly linked.
- [x] Change contains telemetry where appropriate (logs, metrics, etc.).
- [x] Telemetry is meaningful, actionable and does not have the
potential to leak sensitive data.
  • Loading branch information
Yun-Kim committed Jan 25, 2023
1 parent 6bf92f8 commit ab2215a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/test_frameworks.yml
Expand Up @@ -169,9 +169,6 @@ jobs:
- name: Install Dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: flit install --symlink
- name: Pin SQLAlchemy
# https://github.com/encode/databases/issues/512
run: pip install "SQLAlchemy==1.4.41"
- name: Inject ddtrace
run: pip install ../ddtrace
- name: Test
Expand Down

0 comments on commit ab2215a

Please sign in to comment.