Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream issue celery/celery#4875 closed #4649

Closed
github-actions bot opened this issue Nov 30, 2022 · 2 comments · Fixed by #5381
Closed

Upstream issue celery/celery#4875 closed #4649

github-actions bot opened this issue Nov 30, 2022 · 2 comments · Fixed by #5381
Assignees
@emmettbutler

Comments

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited

Upstream issue celery/celery#4875 referenced in the file:

has been closed.

The code referencing this issue could potentially be updated.
@github-actions github-actions bot added the stale label Dec 31, 2022
@github-actions github-actions bot removed the stale label Jan 15, 2023
@Yun-Kim
Copy link
Contributor

Yun-Kim commented Jan 25, 2023

It appears that this celery bug has been resolved for 4.5 and 5.0.3.

@github-actions github-actions bot added the stale label Feb 25, 2023
@emmettbutler
Copy link
Collaborator

I tried removing the code referenced by the comment, and it causes the test tests/contrib/celery/test_integration.py::CeleryDistributedTracingIntegrationTask::test_distributed_tracing_propagation_async to fail. As far as I can tell from about an hour of investigation, the celery fix only affects "hybrid messages" (those that blend protocol 1 and 2 syntax), which our test suite doesn't use.

@emmettbutler emmettbutler self-assigned this Mar 21, 2023
@emmettbutler emmettbutler mentioned this issue Mar 21, 2023
Merged
15 tasks
@github-actions github-actions bot removed the stale label Mar 22, 2023
emmettbutler added a commit that referenced this issue Mar 22, 2023
@emmettbutler
fix(celery): remove reference to github issue (#5381)
85f1805 
The issue referenced was
[resolved](celery/celery#6374), but it actually
does not apply to the bit of code it's pointing to.

Fixes #4649

I tried removing the code referenced by the comment, and it causes the
test
`tests/contrib/celery/test_integration.py::CeleryDistributedTracingIntegrationTask::test_distributed_tracing_propagation_async`
to fail. As far as I can tell from about an hour of investigation, the
celery [fix](celery/celery#4356) only affects
"hybrid messages" (those that blend protocol 1 and 2 syntax as part of a
rolling Celery upgrade), which our test suite doesn't use.
IlyaMichlin pushed a commit to IlyaMichlin/dd-trace-py that referenced this issue Mar 30, 2023
@emmettbutler @IlyaMichlin
fix(celery): remove reference to github issue (DataDog#5381)
530c81f 
The issue referenced was
[resolved](celery/celery#6374), but it actually
does not apply to the bit of code it's pointing to.

Fixes DataDog#4649

I tried removing the code referenced by the comment, and it causes the
test
`tests/contrib/celery/test_integration.py::CeleryDistributedTracingIntegrationTask::test_distributed_tracing_propagation_async`
to fail. As far as I can tell from about an hour of investigation, the
celery [fix](celery/celery#4356) only affects
"hybrid messages" (those that blend protocol 1 and 2 syntax as part of a
rolling Celery upgrade), which our test suite doesn't use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmettbutler emmettbutler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(celery): remove reference to github issue DataDog/dd-trace-py
2 participants
@emmettbutler @Yun-Kim