[internal] Add rate limit effective sample rate #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
approved these changes
Sep 5, 2019
…to brettlangdon/limiter.rate
…to brettlangdon/limiter.rate
|
Merged this code into #1020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR is merging into
brettlangdon/datadog.samplernotmasterThis PR adds in
RateLimiter.effective_rateto return the effective sample rate at that time based on the total number of traces seen vs the number of sampled traces in any given 1s rolling window.TODO:
RateLimiter.effective_rate_dd.limit_psrtag on spans