[core] Add HTTPS support #1055
[core] Add HTTPS support #1055
Conversation
raylu
force-pushed
the
https
branch
3 times, most recently
from
f59d3b9
to
7f02d68
Compare
|
rebasing on top of what got merged this morning (LMK if this is not necessary) EDIT: oof, didn't realize that would un-approve my PR. I should probably just leave this alone... |
|
(@berkowitzi fixed passing the |
tests/test_api.py
Outdated
| api = API('localhost', 8126, '/path/to/uds') | ||
| assert str(api) == '/path/to/uds' | ||
| assert str(api) == 'http:///path/to/uds' |
There was a problem hiding this comment.
that was my initial plan, but then how do you signify HTTPS + UDS? should it just not be allowed?
There was a problem hiding this comment.
https means HTTP over TLS. AFAIK, TLS runs normally on TCP.
So I don't think we should care about Unix Domain Socket + TLS.
By the way, unix:///path/to/uds is not accurate. In fact, we speak HTTP over Unix Domain Socket. So we should probably write http+unix or something.
unix:///path/to/uds is an abbreviated notation.
There was a problem hiding this comment.
I just want to make sure that this PR is consistent with #1054.
There was a problem hiding this comment.
ok. I went with unix:// for both HTTP and HTTPS
ddtrace/internal/writer.py
Outdated
| @@ -193,8 +193,7 @@ def put(self, item): | |||
| Queue.put(self, item, block=False) | |||
| except Full: | |||
| # If the queue is full, replace a random item. We need to make sure | |||
| # the queue is not emptied was emptied in the meantime, so we lock | |||
| # check qsize value. | |||
| # the queue was not in the meantime, so we lock and check qsize. | |||
|
I merged down from |
We have collectors deployed behind an AWS NLB that does TLS termination so we'd like HTTPS support.
This will have conflicts with #1054.