Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: always set rate limit metric #1060

Merged
merged 4 commits into from
Oct 17, 2019
Merged

core: always set rate limit metric #1060

merged 4 commits into from
Oct 17, 2019

Conversation

brettlangdon
Copy link
Member

No description provided.

@brettlangdon brettlangdon requested a review from a team as a code owner September 16, 2019 13:54
majorgreys
majorgreys requested changes Sep 16, 2019
View reviewed changes
Copy link
Collaborator

@majorgreys majorgreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the reason for this change?

@brettlangdon
Copy link
Member Author

We were only setting this metric if the rate limiter allowed the span, but it is actually 100% needed when the rate limiter did not allow the span.

However, it is easy enough and useful for debugging purposes to always set it regardless of rate limiter outcome.

jd
jd previously approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the reason for the change in the commit message would be even better 🦀

@brettlangdon
Copy link
Member Author

I'll add a comment in code

@brettlangdon brettlangdon merged commit 1f021a8 into master Oct 17, 2019
@brettlangdon brettlangdon deleted the brettlangdon/rate.limit.metric branch October 17, 2019 13:17
@majorgreys majorgreys added this to the 0.31.0 milestone Oct 31, 2019
@majorgreys majorgreys changed the title [core] Always set rate limit metric core: always set rate limit metric Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majorgreys majorgreys majorgreys requested changes

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brettlangdon @jd @majorgreys