tracer: fix configure(collect_metrics) argument #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
force-pushed
the
fix-delay
branch
2 times, most recently
from
915179f
to
a53c0ca
Compare
- The current code does not allow to disable collect_metrics by passing `False` to it. - The recent change from 2c41f15 made the hack in test_runtime_metrics to change the FLUSH_INTERVAL a noop, making the test taking 20 seconds to complete. This patch fixes both issues by allowing the `collect_metrics` arguments to be a boolean or a float representing the interval in seconds to use to collect the runtime metrics. This makes sure users can disabled runtime metrics at any time, and fixes the test for running in a less than a second.
brettlangdon
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falseto it.
in test_runtime_metrics to change the FLUSH_INTERVAL a noop, making the test
taking 20 seconds to complete.
This patch fixes both issues by allowing the
collect_metricsarguments to bea boolean or a float representing the interval in seconds to use to collect the
runtime metrics. This makes sure users can disabled runtime metrics at any
time, and fixes the test for running in a less than a second.