Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: add lang and tracer_version tags to runtime metrics #1069

Merged
merged 2 commits into from
Sep 24, 2019
Merged

runtime: add lang and tracer_version tags to runtime metrics #1069

merged 2 commits into from
Sep 24, 2019

Conversation

jd
Copy link
Contributor

@jd jd commented Sep 23, 2019

No description provided.

@jd jd requested a review from a team as a code owner September 23, 2019 14:17
@jd jd mentioned this pull request Sep 23, 2019
Merged
brettlangdon
brettlangdon previously approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while lang might be a little redundant for some metrics, I like the consistency 👍

@jd
Copy link
Contributor Author

jd commented Sep 23, 2019

Lowercased the Python tag. I mean the python tag.

brettlangdon
brettlangdon approved these changes Sep 24, 2019
View reviewed changes
ddtrace/internal/runtime/tag_collectors.py
"""
required_modules = ['platform']
required_modules = ('platform', 'ddtrace')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, requires itself

@jd jd merged commit 72670cc into DataDog:master Sep 24, 2019
@jd jd deleted the runtime-tags branch September 24, 2019 14:10
@majorgreys majorgreys added this to the 0.30.0 milestone Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majorgreys majorgreys majorgreys left review comments

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jd @majorgreys @brettlangdon