Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Ensure we cast sample rate to a float #1072

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

brettlangdon
Copy link
Member

If a string is passed in then we get the following error:

>>> '1' * (2 ** 64)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: cannot fit 'int' into an index-sized integer

Explicitly cast sample rate to a float to at least raise a TypeError if it isn't "floatable"

@brettlangdon brettlangdon requested a review from a team as a code owner September 25, 2019 18:32
@brettlangdon brettlangdon merged commit 67d5b45 into master Sep 25, 2019
@brettlangdon brettlangdon deleted the brettlangdon/cast.to.float branch September 25, 2019 18:41
@majorgreys majorgreys added this to the 0.30.0 milestone Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants