writer: send internal tracer health metrics less often and disable by default #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current rate of sending metrics every 1 second is too heavy and impacts the performance. Let's do this only every 10 seconds by default, so we're sure our perf impact is quite small.
|
I can't get any trace in datadog after upgrading to 0.30.1. Is there anything I need to configure for this version? It says |
brettlangdon
changed the title
|
for anyone coming here due to #1103 or #1102, this PR has to do with new, internal only stats we are collecting from the tracer. these stats are not related to the collecting/reporting of traces. at this time, the tracer does not compute any stats for traces, all of that work is done by our agent and our backend. these stats are meant to tell us how the Python tracer is functioning. |
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2019
* telemetry: send statistics less often and disable by default (#1094) The current rate of sending metrics every 1 second is too heavy and impacts the performance. Let's do this only every 10 seconds by default, so we're sure our perf impact is quite small. * Disable excepthook metric by default (#1095) * core: rewrite agent writer on new process * no need to reset the queue * add test case * fix linting issues * Assert span was written to the correct queue * Update tests/test_tracer.py Co-Authored-By: Tahir H. Butt <tahir.butt@datadoghq.com>
brettlangdon
added a commit
that referenced
this pull request
Oct 21, 2019
* telemetry: send statistics less often and disable by default (#1094) The current rate of sending metrics every 1 second is too heavy and impacts the performance. Let's do this only every 10 seconds by default, so we're sure our perf impact is quite small. * Disable excepthook metric by default (#1095) * core: rewrite agent writer on new process * no need to reset the queue * add test case * fix linting issues * Assert span was written to the correct queue * Update tests/test_tracer.py Co-Authored-By: Tahir H. Butt <tahir.butt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current rate of sending metrics every 1 second is too heavy and impacts the
performance. Let's do this only every 10 seconds by default, so we're sure our
perf impact is quite small.