core: replace time.time by monotonic clock #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`time.time` might jump around as the clock changes (NTP, leap seconds, etc). It's safer to use monotonic.monotonic to get elapsed time ranges.
|
I've settled and removed the reset() method since it's not used nor tested. :p |
brettlangdon
approved these changes
Oct 23, 2019
|
I actually looked and did not find any (I've exlcuded the tests though). Feel free to point me at some if you know them, I'll PR! |
|
Oh you are right. I was thinking about |
majorgreys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.timemight jump around as the clock changes (NTP, leap seconds, etc).It's safer to use monotonic.monotonic to get elapsed time ranges.