internal: send health metrics on every flush #1129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the sampling logic and goes back to sending stats on every flush.
Since we removed the heavier
sizeof
metrics we should be able to do this no problem.If we find that we do need to limit the frequency again we need to figure out how to still collect all the metrics between each flush (e.g. total traces flushed between each stats flush) and then ensure we flush them in a way that works for sending once per X seconds.