Pull request for clean-msgpack #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor the code to make it simpler: - we only define the useful class at load time based on msgpack availability - we declare methods are static when they are - we use class attributes rather than useless per-instance attribute
We just import msgpack for sure since ddtrace depends on it, it has to be there.
We test with 0.5.0 and above in the CI.
|
Note: this slightly breaks the API because I replaced |
majorgreys
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chord(encoding): remove unnused global variable
refactor(encoding): simplify msgpack/json encoders
This refactor the code to make it simpler:
refactor(encoding): msgpack is a dependency, don't "try" to import it
We just import msgpack for sure since ddtrace depends on it, it has to be
there.
fix(setup): set minimum msgpack version we support
We test with 0.5.0 and above in the CI.