Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(update): use standard Python images for black and flake8 jobs #1206

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

jd
Copy link
Contributor

@jd jd commented Feb 13, 2020

There's no need to pull our custom images there.

@jd jd requested a review from a team as a code owner February 13, 2020 15:14
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but shouldn't matter too much either no? I mean at least we should have the image cached anyways

@jd
Copy link
Contributor Author

jd commented Feb 13, 2020

Yeah, it's mainly to simplify the CI a bit where it does things that are not required. Not a huge gain, but it makes it clearer that this can be run a standard Python env.

brettlangdon
brettlangdon previously approved these changes Feb 13, 2020
.circleci/config.yml Outdated Show resolved Hide resolved
There's no need to pull our custom images there.
@jd jd merged commit da6e87e into DataDog:master Feb 14, 2020
@jd jd deleted the use-standard-python-img branch February 14, 2020 14:21
@majorgreys majorgreys added this to the 0.34.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants