fix(django): patch staticmethods in views #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
previously approved these changes
Mar 5, 2020
majorgreys
force-pushed
the
majorgreys/django-staticmethods
branch
from
74684fe
to
22832c3
Compare
brettlangdon
approved these changes
Mar 6, 2020
majorgreys
added a commit
that referenced
this pull request
Mar 6, 2020
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234
We added instrumentation to trace Django class-based views in 0.34.0. Unfortunately the way we were patching the view methods did not work when a method was specified as a static method.
This is due to how the
wraptlibrary we vendor resolves attributes to be wrapped usinggetattr. The solution here is a workaround for how we are usingwrapt. I opened GrahamDumpleton/wrapt#153 to confirm this actual behavior is unexpected and that our workaround is correct.