Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Ensure queue is at or over max size before dropping #1399

Merged
merged 3 commits into from
May 14, 2020
Merged

internal: Ensure queue is at or over max size before dropping #1399

merged 3 commits into from
May 14, 2020

Conversation

brettlangdon
Copy link
Member

Clarify the logic on when we drop a trace.

Note: This should effectively not be changing anything, but will clarify the legibility of the code.

@brettlangdon brettlangdon requested a review from a team as a code owner May 4, 2020 15:26
@brettlangdon brettlangdon merged commit 769ba30 into master May 14, 2020
@brettlangdon brettlangdon deleted the brettlangdon/check.maxsize branch May 14, 2020 17:19
@Kyle-Verhoog Kyle-Verhoog added this to the 0.38.0 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brettlangdon @jd @Kyle-Verhoog