internal: Change trace too large message to debug #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
reviewed
May 5, 2020
brettlangdon
changed the title
…s-larger-than-256kb
…s-larger-than-256kb
|
Let me know if you'd rather have something like the trace id of the parent span or something printed when this error occurs. I was not sure how to add that instead from the Trace object. |
jd
approved these changes
May 14, 2020
|
I think that's good enough. That should not happen anyhow, and I don't think having any id will help. 🤷 Thank you @ZStriker19! |
…s-larger-than-256kb
…s-larger-than-256kb
…s-larger-than-256kb
…s-larger-than-256kb
jd
deleted the
zach-groves-change-log-level-for-log-that's-larger-than-256kb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the issue is that we don't accept logs bigger than 256kb: "Any log exceeding 256KB is accepted and truncated by server" and when we log that a trace payload is too large, we print the whole trace, causing a log larger than the acceptable size: https://github.com/DataDog/dd-trace-py/blob/master/ddtrace/api.py#L229
This causes many error level logs to be generated
Which is causing the customer's monitor for error level logs on this application to alert.