fix: raise RuntimeError("threads can only be started once") #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC this happens if you have multiple threads trying to start the writer at the same time because they both emit the first span concurrently. Sounds legit. |
Kyle-Verhoog
approved these changes
May 14, 2020
There was a problem hiding this comment.
@YasuoSasaki thanks for the contribution! This is indeed an issue and the fix is sufficient.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: raise RuntimeError("threads can only be started once").
This occurs due to a race condition on
AgentWriter._startedwhen multiple threads start simultaneously and a writer has not yet been created.