Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

monkey: add better error messages #1430

Merged
merged 4 commits into from
May 12, 2020
Merged

Conversation

Kyle-Verhoog
Copy link
Member

This PR adds the path and module to exceptions generated when errors occur with those values. Before, a generic message was raised which was not at all useful for debugging.

Also formats monkey.py.

These changes are split into two separate commits for ease in reviewing 馃檪

@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner May 12, 2020 16:17
Copy link
Contributor

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you blacked it manually without adding it to pyproject

@Kyle-Verhoog
Copy link
Member Author

ah yes, totally forgot

@Kyle-Verhoog Kyle-Verhoog merged commit 7acba7c into master May 12, 2020
@Kyle-Verhoog Kyle-Verhoog deleted the kylev/monkey-bettererrors branch May 12, 2020 19:03
@Kyle-Verhoog Kyle-Verhoog added this to the 0.38.0 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants