Fix starlette tests #2172
Merged
Fix starlette tests #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
added
the
changelog/no-changelog
Kyle-Verhoog
force-pushed
the
fix
branch
2 times, most recently
from
344c905
to
5ad0613
Compare
brettlangdon
previously approved these changes
Mar 15, 2021
- as per encode/databases#298, sqlalchemy 1.4 removed `RowProxy` which causes `databases` to fail
brettlangdon
approved these changes
Mar 15, 2021
Yun-Kim
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per encode/databases#298, sqlalchemy 1.4 removed
RowProxywhich causesdatabasesto fail.Pin sqlalchemy to 1.3.x for until the issue is resolved upstream.