Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pyramid request span tags for HTTP method and route name #220

Merged
merged 2 commits into from
Mar 13, 2017
Merged

Set pyramid request span tags for HTTP method and route name #220

merged 2 commits into from
Mar 13, 2017

Conversation

johnpkennedy
Copy link

This PR sets the following tags for the pyramid.request span:

  1. http.METHOD
  2. pyramid.route.name

LotharSee
LotharSee reviewed Mar 13, 2017
View reviewed changes
Copy link
Contributor

@LotharSee LotharSee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Let's cover these extra meta to the tests (in tests/contrib/pyramid/test_pyramid.py)

@johnpkennedy
Copy link
Author

I updated the test_pyramid.py and ran rake test.

py27-pyramid17-webtest: commands succeeded
py27-pyramid18-webtest: commands succeeded

palazzem
palazzem approved these changes Mar 13, 2017
View reviewed changes
Copy link

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot also for updating our tests! it looks good to me!

LotharSee
LotharSee approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@LotharSee LotharSee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, all good to me!

@palazzem palazzem self-assigned this Mar 13, 2017
@palazzem palazzem added this to the 0.6.1 milestone Mar 13, 2017
@palazzem palazzem merged commit 82aa10f into DataDog:master Mar 13, 2017
@palazzem palazzem modified the milestones: 0.6.1, 0.7.0 Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

@LotharSee LotharSee LotharSee approved these changes

Assignees

@palazzem palazzem

Labels
enhancement integrations
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnpkennedy @palazzem @LotharSee