ensure db cursors play well with ctx managers. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
approved these changes
Mar 24, 2017
| # https://github.com/DataDog/dd-trace-py/issues/228 | ||
|
|
||
| # context managers aren't supported in earlier versions of pyscopg so | ||
| # skip this test. should we just drop support for < 2.5? |
There was a problem hiding this comment.
We're currently supporting psycopg2 >= 2.4... we should double check if someone is using that version. For now we can keep it.
2.5 is really old. no worries. it only affects tests, should still work.
palazzem
reviewed
Mar 24, 2017
| @@ -43,7 +43,7 @@ envlist = | |||
| {py27,py34,py35,py36}-pyramid-autopatch{17,18}-webtest | |||
| {py27,py34,py35,py36}-requests{208,209,210,211,212,213} | |||
| {py27,py34,py35,py36}-sqlalchemy{10,11}-psycopg2{27} | |||
| {py27,py34,py35,py36}-psycopg2{24,25,26,27} | |||
| {py27,py34,py35,py36}-psycopg2{25,26,27} | |||
There was a problem hiding this comment.
an update here and we're good: https://github.com/DataDog/dd-trace-py/blob/07e6b08301fe08ca648428719b4b5481d13aeb0b/docs/index.rst#supported-versions
palazzem
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure db cursors play well with ctx managers. Fixes #228