Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aiobotocore] update async with context manager #307

Merged
merged 2 commits into from
Jul 19, 2017

Conversation

palazzem
Copy link

@palazzem palazzem commented Jul 6, 2017

Overview

When using async with, the proxy object isn't returned so the client is not traced. Example:

# traced client
client = aiobotocore.get_session().create_client('s3')

response = await client.get_object(Bucket='something')
async with response['Body'] as stream:
    await stream.read()

@palazzem palazzem requested a review from LotharSee July 6, 2017 07:52
@palazzem palazzem modified the milestone: 0.9.1 Jul 6, 2017
@palazzem palazzem merged commit 3abc5e3 into master Jul 19, 2017
@palazzem palazzem deleted the palazzem/aiobotocore-response branch July 19, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants