[dual sampling] support -1 as a priority sampling value #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJF
previously approved these changes
Dec 27, 2017
docs/index.rst
Outdated
| @@ -358,7 +358,8 @@ Priority sampling | |||
| Priority sampling consists in deciding if a trace will be kept by using a `priority` attribute that will be propagated | |||
| for distributed traces. Its value gives indication to the Agent and to the backend on how important the trace is. | |||
|
|
|||
| - 0: Don't keep the trace. | |||
| - -1: The user asked not to keep the trace. | |||
| - 0: The sampler automatically decided not to keep the trace. | |||
| - 1: The sampler automatically decided to keep the trace. | |||
| - 2: The user asked the keep the trace. | |||
talwai
previously approved these changes
Dec 27, 2017
palazzem
reviewed
Jan 3, 2018
docs/index.rst
Outdated
| @@ -358,9 +358,10 @@ Priority sampling | |||
| Priority sampling consists in deciding if a trace will be kept by using a `priority` attribute that will be propagated | |||
| for distributed traces. Its value gives indication to the Agent and to the backend on how important the trace is. | |||
|
|
|||
| - 0: Don't keep the trace. | |||
| - -1: The user asked not to keep the trace. | |||
There was a problem hiding this comment.
Same suggestions for other tracers. What if we provide a module with priority values? something like http://www.django-rest-framework.org/api-guide/status-codes/#status-codes
# NOTE: all names are just an examples
from ddtrace.ext import priority
# somewhere in the code
ctx.sampling_priority = priority.KEEP_TRACE
ufoot
force-pushed
the
christian/dualsampling
branch
2 times, most recently
from
484145c
to
20dd515
Compare
ufoot
force-pushed
the
christian/dualsampling
branch
from
31915fb
to
416ce8d
Compare
palazzem
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usage of
-1as a priority sampling value. Here there's no real impact, it's mostly about writing tests ensuring this works and updating the docs.