[requests] add unpatch and double-patch protection #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
commented
Jan 29, 2018
| _u(requests.Session, 'request') | ||
|
|
||
|
|
||
| def _session_initializer(func, instance, args, kwargs): |
There was a problem hiding this comment.
Not a big deal now, but it's required later
palazzem
force-pushed
the
palazzem/requests-double-patching
branch
from
405f3f6
to
9c78018
Compare
palazzem
commented
Jan 29, 2018
| eq_(len(spans), 1) | ||
| s = spans[0] | ||
| eq_(s.get_tag(http.METHOD), 'GET') | ||
| eq_(s.get_tag(http.STATUS_CODE), '500') | ||
| eq_(s.error, 1) | ||
|
|
||
|
|
||
| def get_traced_session(): |
There was a problem hiding this comment.
Removed since a not monkey-patched class was used. With this new test suite, we ensure that patch() really updates the Session class.
LotharSee
reviewed
Jan 29, 2018
| from .patch import TracedSession, patch | ||
| __all__ = ['TracedSession', 'patch'] | ||
| from .patch import TracedSession, patch, unpatch | ||
| __all__ = ['TracedSession', 'patch', 'unpatch'] |
There was a problem hiding this comment.
Is the deal to expose and document the unpatch method for this integration?
There was a problem hiding this comment.
No actually no, it has been exposed only for testing purposes. We probably don't want to suggest patching and unpatching at runtime. Anyway there is a plan to refactor the patching system, since we should start to introduce settings for each integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
patch()unpatch()to remove tracing__init__so that we can set later (another PR) settings from env vars