flask: don't override code of already handled errors #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
previously approved these changes
Jan 31, 2018
| """ | ||
| # when we teardown the span, ensure we have a clean slate. | ||
| span = getattr(g, 'flask_datadog_span', None) | ||
| setattr(g, 'flask_datadog_span', None) |
This is a refactoring of how we handle flask requests. We don't use signals to teardown requests and instead use the `teardown_request` handler. This always runs so it's a more reliable way of closing the request. Signals are only used to annotate spans that received an error (which a user may handler). This also reduces the difference between signal enabled and disabled mode which is nice. This should fix #390.
|
This PR includes now #410 as a generic improvement. |
palazzem
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of how we handle flask requests. We don't use
signals to teardown requests and instead use the
teardown_requesthandler. This always runs so it's a more reliable way of closing the
request. Signals are only used to annotate spans that received an error
(which a user may handler), and not to finish requests that may have been
successful.
This also reduces the difference between signal enabled and disabled
mode which is nice.
This should fix #390.