[dbapi] remove sql.query tag so that the content is obfuscated in the Agent
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LotharSee
previously approved these changes
Feb 21, 2018
palazzem
force-pushed
the
palazzem/dbapi-query-tag
branch
from
52aed85
to
b3d8b54
Compare
LotharSee
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This patch removes the
sql.querytag otherwise it's not properly obfuscated in the Trace Agent (reference: https://github.com/DataDog/datadog-trace-agent/blob/0067fb9a869a949e018e15befadb56338c5fa798/quantizer/sql.go#L228-L236). This issue impacts only MySQL integrations and NOTpsycopg2orsqlalchemywith Postgres driver.