[django] Fix django test flake #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I verified this fix works by re-running CI until I found one that broke, SSHing in, verifying that the tests continue to fail, applying this fix, then verifying that the tests are passing (and that they break again when fix is unpatched). |
bmermet
approved these changes
Mar 29, 2018
palazzem
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do this by ensuring that only one of MIDDLEWARE and MIDDLEWARE_CLASSES gets patched.
Downside: I still don't completely understand why it would flake, I know there is some kind of race in the tests happening where the insert_trace_middleware function gets called multiple times but I couldn't figure out what it is. I was starting to spend a little too much time on this, so I figured you'd at least enjoy a solution.
I just made sure that insert_trace_middleware is idempotent now.