[celery] fixing ddtrace-run broke celery support #469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves this issue : when patching celery with the
ddtrace-run
command, the import fails silently and Celery is not patched. The exception raised is'module' object has no attribute 'argv'
, stemming from the way our tracer patches libraries:argv
is not passed, and causes the fail celery import as the library needs it.The PR replaces argv when it is required.
I have tested this change with a Celery app and a
pymysql
app, it seems to work fine.