[core] Configure the root logger #536
Conversation
| @@ -6,6 +7,10 @@ | |||
|
|
|||
| __version__ = '0.12.1' | |||
|
|
|||
| # configure the root logger | |||
There was a problem hiding this comment.
I'm not sure this is the best practice, I asked @SeanOC for his thoughts:
we might want to do something a bit more involved in the future but for now that should be a reasonable start and should play nice with Django's logging setup (they definitely do things the Pythonic way but they have a much more sophisticated default setup than most python apps do out of the box)
| @@ -6,6 +7,10 @@ | |||
|
|
|||
| __version__ = '0.12.1' | |||
|
|
|||
| # configure the root logger | |||
| logging.basicConfig() | |||
There was a problem hiding this comment.
Configuring where the logs go from a library/module (rather than the application) is generally frowned upon:
https://www.loggly.com/ultimate-guide/python-logging-basics/#logging-from
and https://sweetness.hmmz.org/2013-11-18-use-of-logging-package-from-within-a-library.html (the Explicitly configuring handlers section)
There was a problem hiding this comment.
This change has been reverted in this PR: #556
A new 0.13.1 release is scheduled for today. Thanks for the heads-up!
Overview
Add configuration of the root logger so that error messages are not displayed in cases like #513.