-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed HTTPConnection leaking #542
Conversation
Closing the connection after use to ensure sockets do not leak.
Thanks @mackeyja92 for the contribution! We'll take a look to test properly the change. I'll reach you once we schedule this PR for the next release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, we should see if we can add some sort of a regression test for this so that we don't make the same mistake in the future.
@Kyle-Verhoog You could run your tests with the python argument |
If it's a warning, can we detect them via dd-trace-py/tests/contrib/celery/test_task_deprecation.py Lines 24 to 37 in 04b6e1d
If it's possible, it's enough to check that no warnings are raised. |
Closing the connection after use to ensure sockets do not leak.
Fixes #541