[tests] Update the integrations libraries versions to the latest possible. #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
force-pushed
the
labbati/integrations-latest-versions
branch
from
1324d03
to
9f032ca
Compare
…ible.
A few notes follow for specific libraries besides updates you can see in the code itself
*tornado*
- not possible to udate to 5.x, postponing
*elasticsearch*
- added 6.3
- a test had to be updated because `doc_type` arg was optional before, it is not anymore.
*falcon*
- added 1.3, 1.4
- a small change to a test class was necessaries because of a new expected property that must exists in the TestCase class.
*flask*
- added version 1.0
- our integration flask_cache does not support flask 1.
*pymongo/mongoengine*
- mongoengine: updated to latest
- pymongo: added 3.6. Latest stable is 3.7, but our integration fails to trace at least inserts.
Example:
1) ['count here.are.songs', 'count here.are.songs', 'count here.are.songs', 'count here.are.songs', 'delete here.are.songs {"artist": "?"}', 'delete here.are.songs {"artist": "?"}', 'drop here.are.songs', 'insert here.are.songs']
2) [u'count here.are.songs', u'count here.are.songs', u'count here.are.songs', u'count here.are.songs', u'delete here.are.songs {"artist": "?"}', u'delete here.are.songs {"artist": "?"}', u'drop here.are.songs']
labbati
force-pushed
the
labbati/integrations-latest-versions
branch
3 times, most recently
from
7c80da4
to
0751aee
Compare
…ase of multidict 4.4 Suddenly master started to fail when before was passing just fine. The difference in the dependency tree showed that the only package updated was multidict. Fails : aiobotocore==0.2.3,aiohttp==1.3.5,...,multidict==4.4.1,...,yarl==0.9.8 Succeed: aiobotocore==0.2.3,aiohttp==1.3.5,...,multidict==4.3.1,...yarl==0.9.8 The versions we are testing are pretty old and they are not compatible with multidict 4.4.x that was just released a few days ago. The issue aio-libs/aiohttp#3277 was opened as this issue can potentially impact other users too.
labbati
force-pushed
the
labbati/integrations-latest-versions
branch
from
0751aee
to
0c44922
Compare
Kyle-Verhoog
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few notes follow for specific libraries besides updates you can see in the code itself
Moreover, we recently discovered of a problem with
aiohttpdependency tree and opened an GH issue about it: aio-libs/aiohttp#3277