[tests] Refactor tox.ini file #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
force-pushed
the
labbati/refactor-tox-file
branch
6 times, most recently
from
5d1a820
to
bedcf85
Compare
- We defined specific commands depending on the real command and not on
the dependency graph
- We removed django testenv special configurations that were no longer
used after we added redis{210} in place of redis to the dependency list
- We sorted alphabetically the various envs
- We do not rely anymore on checksum of tox.ini to invalidate cache
labbati
force-pushed
the
labbati/refactor-tox-file
branch
from
bedcf85
to
75632f8
Compare
labbati
force-pushed
the
labbati/refactor-tox-file
branch
from
ebabac6
to
75632f8
Compare
| @@ -10,6 +10,15 @@ test_runner: &test_runner | |||
| image: datadog/docker-library:dd_trace_py_1_1_0 | |||
| env: | |||
| TOX_SKIP_DIST: True | |||
| restore_cache_step: &restore_cache_step | |||
There was a problem hiding this comment.
We should probably document the usage and motivation behind Environment.CACHE_EXPIRE_HASH so that it doesn't look like magic or require much digging in the future 😄
There was a problem hiding this comment.
Great idea. Will do right now! 👍
There was a problem hiding this comment.
@Kyle-Verhoog just pushed an update. Would you please take a look at it? Thanks
Kyle-Verhoog
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the dependency graph
used after we added redis{210} in place of redis to the dependency list