Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow django cache to be seen as a different service. #629

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

fedj
Copy link
Contributor

@fedj fedj commented Oct 3, 2018

DEFAULT_CACHE_SERVICE is introduced to override the service name used for the span dedicated to the cache.
If the value is set, the django.cache span will appear as a different service. If not set, the current
behavior is kept.

Fix #528

DEFAULT_CACHE_SERVICE is introduced to override the service name used for the span dedicated to the cache.
If the value is set, the django.cache span will appear as a different service. If not set, the current
behavior is kept.
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kyle-Verhoog Kyle-Verhoog added this to the 0.15.0 milestone Oct 4, 2018
@Kyle-Verhoog Kyle-Verhoog merged commit 9d196d4 into master Oct 4, 2018
@Kyle-Verhoog Kyle-Verhoog deleted the ph-jeanneret/django-cache-service-name branch October 4, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants