Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Span.span_type tests #633

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Conversation

fedj
Copy link
Contributor

@fedj fedj commented Oct 5, 2018

Span.span_type is set in the code but not checked in tests. This PR adds tests for some untested contribs

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fedj fedj merged commit f2fe972 into master Oct 5, 2018
@fedj fedj deleted the ph.jeanneret/test-contrib-span-type branch October 5, 2018 19:13
@palazzem palazzem added this to the 0.15.0 milestone Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants