Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Skip flaky TestWorkers.test_worker_multiple_traces test case #643

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

brettlangdon
Copy link
Member

This test is non-deterministic and will fail for no reason and so should be skipped.

The problem we are having is that this test relies on us being able to correctly time the flush intervals from the writer, which we are unable to do at this time.

If we can tweak the writer internals in a way where we can make it deterministic then we should revive this test case.

@brettlangdon
Copy link
Member Author

of course, now the flaky test passes and another one fails...

Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove the test altogether, but I'm fine either way. Yay less flakiness 😄

@brettlangdon
Copy link
Member Author

I think keeping it here but skipping is good for two reasons:

  1. If we do find a way to make it work we can re-enable, there is probably some value is this test case
  2. If we go to write a similar test we can see this skipped test to let us know that this type of test doesn't work right now

@brettlangdon brettlangdon merged commit 88a9278 into master Oct 11, 2018
@brettlangdon brettlangdon added this to the 0.15.0 milestone Oct 11, 2018
@brettlangdon brettlangdon deleted the brettlangdon/skip.flaky.test branch October 12, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants